Skip to content

Add nmcpPublishDeployment task#251

Merged
martinbonnin merged 3 commits intoGradleUp:mainfrom
marcphilipp:marc/publish-deployment-task
Apr 30, 2026
Merged

Add nmcpPublishDeployment task#251
martinbonnin merged 3 commits intoGradleUp:mainfrom
marcphilipp:marc/publish-deployment-task

Conversation

@marcphilipp
Copy link
Copy Markdown
Contributor

@marcphilipp marcphilipp commented Apr 26, 2026

Part of #250.

@marcphilipp marcphilipp mentioned this pull request Apr 26, 2026
Closed
marcphilipp
marcphilipp commented Apr 26, 2026
View reviewed changes
Comment thread scripts/integration-tests.sh Outdated
martinbonnin
martinbonnin approved these changes Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Comment thread scripts/integration-tests.sh Outdated
Comment thread nmcp-tasks/src/main/kotlin/nmcp/transport/transport.kt
Comment thread nmcp/src/main/kotlin/nmcp/internal/utils.kt Outdated
@marcphilipp
Copy link
Copy Markdown
Contributor Author

marcphilipp commented Apr 28, 2026

Could you please approve the workflow runs?

@martinbonnin
Copy link
Copy Markdown
Member

martinbonnin commented Apr 28, 2026

Could you please approve the workflow runs?

Done 👍 Sorry I missed that!

@marcphilipp
Copy link
Copy Markdown
Contributor Author

marcphilipp commented Apr 28, 2026

Once again, please 🙏

The way the integration tests are orchestrated seems unconventional and confusing to me. Would you be open to converting them to "regular" functional test using a testing framework of your choice? If so, I'd like to do that first

@martinbonnin
Copy link
Copy Markdown
Member

martinbonnin commented Apr 28, 2026 •
edited
Loading

Once again, please 🙏

Done

Would you be open to converting them to "regular" functional test using a testing framework of your choice?

Are you thinking about testKit ? TestKit is useful to test cacheability, different Gradle versions or error messages but in order to assert success, they introduce another layer of indirection and I've grown to dislike them, not to mention that they behave differently in some cases.

The integration tests here are just regular builds, opentests/kmp in IDEA and you can debug them, etc, just like a regular build.

Edit: in all cases, looks like the tests passed 🎉 Is this good to merge?

@marcphilipp marcphilipp marked this pull request as ready for review April 30, 2026 14:40
@marcphilipp
Copy link
Copy Markdown
Contributor Author

marcphilipp commented Apr 30, 2026

Is this good to merge?

I think so!

@martinbonnin martinbonnin merged commit bb07b8f into GradleUp:main Apr 30, 2026
1 check passed
@martinbonnin
Copy link
Copy Markdown
Member

martinbonnin commented Apr 30, 2026

Thanks!

@marcphilipp marcphilipp changed the title Add nmcpPublishCentralPortalDeployment task Add nmcpPublishDeployment task Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcphilipp @martinbonnin